plugin: fix dialog-main implementation#9179
Merged
vince-fugnitto merged 1 commit intomasterfrom Mar 23, 2021
Merged
Conversation
vince-fugnitto
added
electron
vince-fugnitto
requested review from
RomanNikitenko,
kittaakos and
vitaliy-guliy
kittaakos
approved these changes
Mar 23, 2021
Contributor
kittaakos
left a comment
kittaakos
left a comment
There was a problem hiding this comment.
The code looks good to me. I have verified it, and it worked.
Thank you so much for the test extension. It was super easy to verify the fix 👍
vince-fugnitto
force-pushed
the
vf/plugin-dialog
branch
from
2818bb8 to
3cfc575
Compare
The following commit updates the `dialog` extension API. The changes include updating the use of factories in order to use the `fileDialogService` which already properly handles the dialog logic, and includes implementations in both the `browser` and `electron`. The changes also include: - adding `title` as an available prop - adding extra handling when using both `canSelectFiles` and `canSelectFolders` simultaenously in the electron target. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/plugin-dialog
branch
from
3cfc575 to
94383d5
Compare
Member
Author
|
@kittaakos thank you for taking the time to review, I generalized the documentation a bit :) |
RomanNikitenko
approved these changes
Mar 23, 2021
Contributor
RomanNikitenko
left a comment
RomanNikitenko
left a comment
There was a problem hiding this comment.
I tested on Linux for electron and browser assemblies.
I see the following differences against the master branch:
- for the
electronassembly the system dialog is displayed for the both commands - for the
electronassembly the system allows to select only folders (not files) when I use theDialog: Opencommand - the custom title is displayed for a dialog
I see the same behavior for VS Code. It works well for me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #9177
The following commit updates the
dialogextension API. The changes include updating the use of factories in order to use thefileDialogServicewhich already properly handles the dialog logic, and includes implementations in both thebrowserandelectron.The changes also include:
titleas an available propcanSelectFilesandcanSelectFolderssimultaenously in the electron target.How to test
Using the following plugin verify that the
browserandelectronapplications correctly trigger their respective open and save dialogs through the commands:Dialog: OpenDialog: SaveReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com