eslint: update rules for 'theia.d.ts'#9200
Merged
vince-fugnitto merged 1 commit intomasterfrom Mar 22, 2021
Merged
Conversation
vince-fugnitto
added
quality
Member
|
Will this make contributing to this file harder whenever someone brings code over from VS Code? |
Member
Author
It shouldn't, code that was copied was not properly formatted and now it should be enforced. |
paul-marechal
approved these changes
Mar 18, 2021
Member
paul-marechal
left a comment
paul-marechal
left a comment
There was a problem hiding this comment.
I see you also fixed typos, LGTM
vince-fugnitto
force-pushed
the
vf/eslint-dts
branch
2 times, most recently
from
7642fa4 to
c5c23aa
Compare
The following commit enables linting of the 'theia.d.ts' file which had many linting violation and caused issues during reviews. The code has also been fixed to meet linting rules, and should be fine for the future. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/eslint-dts
branch
from
c5c23aa to
9efa6a6
Compare
Member
Author
|
@benoitf @RomanNikitenko any objections to making |
Contributor
|
@vince-fugnitto I saw the PR and I have no objection 👍 (I like it) |
Member
Author
|
I'll merge, there may be some errors from the file if others do not rebase their pull-requests (although I do not see many open pull-requests that affect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The following commit enables linting of the 'theia.d.ts' file which had many linting violation and caused issues during reviews. The code has also been fixed to meet linting rules, and should be fine for the future.
How to test
Verify that the build successfully passes, linting should be fixed for
theia.d.ts.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com