fixed typos in preference-array.css closing issue #9243#9270
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Mar 29, 2021
Merged
fixed typos in preference-array.css closing issue #9243#9270vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
Conversation
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
@arabellastrange thank you for your first contribution 👍
In order to accept the changes, please complete the following:
- please sign the eclipse contributor agreement (eca) with the same email as your
sign-off- it is the reason for the failed CI check - after completing the updates make sure to squash commits - in the case you might have multiple.
vince-fugnitto
added
css
Author
|
Thank you for the reply! I am working on fixing this at the moment |
Signed-off-by: chadha <c.degachi@student.tudelft.nl>
vince-fugnitto
approved these changes
Mar 29, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
@arabellastrange thank you for the updates, we hope its the first of many 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chadha Degachi C.Degachi@student.tudelft.nl
What it does:
Fixes: #9243
This request fixes three typos in the preference-array.css file in the padding variable name.
How to test
To test this fix, navigate to the application preferences from File -> Settings -> Open Preferences and scroll to the Custom Data section in the CSS completion section. Add a number of values and inspect (with chrome developer tools) the displayed array to verify correct behaviour.
Review checklist
Reminder for reviewers