[task]: Update TaskConfigurationManager on Workspace Location Change#9331
Merged
kenneth-marut-work merged 1 commit intoeclipse-theia:masterfrom Apr 20, 2021
Conversation
TaskConfigurationManager on Workspace Location Change
bd18043 to
8dbc86b
Compare
Signed-off-by: Colin Grant <colin.grant@ericsson.com>
8dbc86b to
476c984
Compare
kenneth-marut-work
approved these changes
Apr 20, 2021
Contributor
kenneth-marut-work
left a comment
There was a problem hiding this comment.
Tested and working 👍
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Colin Grant colin.grant@ericsson.com
What it does
Fixes #9329 by adding a listener for
onLocationChangedto theTaskConfigurationManagerto ensure that it updates the target of its workspace proxy when a workspace file is created.In addition, it fires a changed event when the workspace proxy is changed, parallel to the events fired when new folder-scope models are created.
How to test
File > Save Workspace as ...and save the workspace wherever you'd like.Review checklist
Reminder for reviewers