Apply Secrets plugin API#9463
Conversation
vinokurig
requested review from
RomanNikitenko,
azatsarynnyy,
marcdumais-work,
paul-marechal and
vzhukovs
azatsarynnyy
left a comment
azatsarynnyy
left a comment
There was a problem hiding this comment.
Tested it with the provided extension - works as expected.
| "ajv": "^6.5.3", | ||
| "body-parser": "^1.17.2", | ||
| "cookie": "^0.4.0", | ||
| "keytar": "7.7.0", |
There was a problem hiding this comment.
I confirmed that the keytar dependency is license compatible
There was a problem hiding this comment.
Do I need to create a CQ for this package?
There was a problem hiding this comment.
Do I need to create a CQ for this package?
@vinokurig I don't think so, it falls under the following use-case. I confirmed that the dependency looks fine, you may double-check if you like following this process.
| * Copyright (c) Microsoft Corporation. All rights reserved. | ||
| * Licensed under the MIT License. See License.txt in the project root for license information. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
| // code copied and modified from https://github.com/microsoft/vscode/blob/1.55.2/src/vs/workbench/services/credentials/common/credentials.ts#L12 |
There was a problem hiding this comment.
We likely need a CQ for the two files, can you add a link to the corresponding CQ when ready (unless it is already covered)?
https://github.com/microsoft/vscode/blob/1.55.2/src/vs/workbench/services/credentials/common/credentials.ts#L12
https://github.com/microsoft/vscode/blob/1.55.2/src/vs/platform/native/electron-main/nativeHostMainService.ts#L679-L771
There was a problem hiding this comment.
vince-fugnitto
added
CQ Required (deprecated)
vinokurig
force-pushed
the
theia-9348
branch
2 times, most recently
from
b981597 to
777dd19
Compare
|
@vince-fugnitto is it OK to merge? |
@vinokurig No? The CQ is not yet approved. |
|
@vince-fugnitto The CQ has been approved is there any other objections? |
@vinokurig the lat comment I see is:
Is it somehow not refreshed? |
|
@vinokurig I've always waited for there to be an explicit approval comment as part of the CQ, namely:
|
Sorry, forgot to paste my screenshot:
OK, let's wait for the comment. |
vinokurig
force-pushed
the
theia-9348
branch
3 times, most recently
from
5ab76ed to
1542bb1
Compare
|
@vince-fugnitto since the CQ has been approved I am going to merge it tomorrow, if now other objections? |
vinokurig
force-pushed
the
theia-9348
branch
2 times, most recently
from
43030c9 to
a9df031
Compare
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
3 participants
Signed-off-by: Igor Vinokur ivinokur@redhat.com
What it does
Corresponding CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=23332.
Apply Secrets plugin API: https://code.visualstudio.com/updates/v1_53#_secrets-api
fixes #9348
How to test
Get Passwordcommand and see a notification with empty (undefined) password.Set Passwordcommand and see a notification about password change.Get Passwordcommand and see a notification with the updated password.Delete Passwordcommand and see a notification about password change.Get Passwordcommand and see a notification with empty (undefined) password.Review checklist
Reminder for reviewers