8691 support in operator for when clauses#9492
Conversation
paul-marechal
changed the title
danarad05
force-pushed
the
8691-support-in-opertor-for-when-clauses
branch
from
76a8ce5 to
c4199df
Compare
EstherPerelman
force-pushed
the
8691-support-in-opertor-for-when-clauses
branch
3 times, most recently
from
9b9194d to
9da71a3
Compare
|
@paul-marechal @tsmaeder @RomanNikitenko |
Anyone🤔? |
RomanNikitenko
left a comment
RomanNikitenko
left a comment
There was a problem hiding this comment.
Theia has got Support new vscode 'in' operator for 'when' clauseswith the Monaco upgrade.
I tested master branch according to the How to test section of the PR - it works well.
If I understand correctly, the current PR contains refactoring related to this area. The changes look good for me, I tested them - it works.
@EstherPerelman
there is one failing job - please pick up last changes from the master and check that all jobs are successful before merging the PR
1) Supporting ContextKeyExpression types 2) Enabled parsing of `when` clauses to the new ContextKeyExpression types.
EstherPerelman
force-pushed
the
8691-support-in-opertor-for-when-clauses
branch
from
9da71a3 to
2599e8f
Compare
@RomanNikitenko Thanks for approving! |
|
I have restarted all checks, waiting... |
@RomanNikitenko Thank you it passed! Are you able to merge? |
4 participants
What it does
Fixes #8691
How to test
Note: This PR is dependent on merging of #9154 as it requires latest monaco typings.
Open a project - i.e. "helloworld sample" from "vscode-extension-samples"
Update
extension.tsto setContext i.e.:Add to sample
package.json- menus dependent on context key:Run as hosted plugin
Run command "extension.helloWorld" from command palette
Right click on "src" folder and see that "Hello World" command is added to opened context menu:
Right-clicking on file and not folder - doesn't display "Hello World" command in context menu:
Review checklist
Reminder for reviewers