Deduplicate InMemoryTextResource#9504
Merged
colin-grant-work merged 2 commits intoeclipse-theia:masterfrom May 26, 2021
Merged
Conversation
Signed-off-by: Gabriel Bodeen <gabriel.bodeen@ericsson.com>
Signed-off-by: Gabriel Bodeen <gabriel.bodeen@ericsson.com>
vince-fugnitto
approved these changes
May 20, 2021
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes work well for me 👍
- confirmed that
rename previewworks as on master. - confirmed that
search-in-workspacerenameworks. - confirmed that
search-in-workspacerename now properly selects the proposed changes.
Contributor
Author
|
Incidentally, I noticed that this fixes another cosmetic issue: In the search-and-replace tree, an element will now stay selected after clicking it. This happens because the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #9191 and an unreported issue with Search-In-Workspace: when clicking a search-and-replace suggestion, the preview editor should reveal the line on which the suggested change occurs. Currently on
master, only the first suggested change in a file will be revealed.(Please let me know if these should be separate PRs or instead should be flattened into a single commit. I found the latter issue while testing the fix for issue 9191, and it was unsatisfying to submit a fix that still looked broken.)
How to test
Test Bulk-Edit:
mem-txtscheme.Test Search-In-Workspace:
Review checklist
Reminder for reviewers