Track index in Pref Tree to facilitate automatic scrolling#9549
Merged
colin-grant-work merged 1 commit intomasterfrom Jun 3, 2021
Merged
Track index in Pref Tree to facilitate automatic scrolling#9549colin-grant-work merged 1 commit intomasterfrom
colin-grant-work merged 1 commit intomasterfrom
Conversation
Signed-off-by: Colin Grant <colin.grant@ericsson.com>
Contributor
Author
|
@shuyaqian, would you mind testing this to ensure it fixes your problem? |
vince-fugnitto
approved these changes
Jun 3, 2021
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed that the tree expansion works much better following the changes.
When expanding nodes in the tree, the automatic scroll no longer pushes the expanded node outside the view 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #9532 by tracking the index in the tree rather than using the index from the model. Previously, the index used for automatic scrolling didn't match any node in the TreeWidget's display.
Some additional cleanup of the filtering process is possible, but I prefer to defer that to a separate PR after #9439 is merged.
How to test
Review checklist
Reminder for reviewers