application-package: refine config typings#9568
Merged
paul-marechal merged 1 commit intomasterfrom Jun 9, 2021
Merged
Conversation
1 task
paul-marechal
force-pushed
the
mp/application-props-typing
branch
2 times, most recently
from
f7919d8 to
2e51dea
Compare
vince-fugnitto
added
extensibility
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed that:
- partial updates with
FrontendApplicationConfigProvider.setare supported. - partial updates with
BackendApplicationConfigProvider,setare supported. - confirmed that there are no regressions when starting the application, the
applicationName(which is updated for bothexample-browserandexample-electronis properly updated and reflected. - CI is green and the new tests successfully pass.
packages/core/src/browser/frontend-application-config-provider.spec.ts
Outdated
Show resolved
Hide resolved
packages/core/src/browser/frontend-application-config-provider.spec.ts
Outdated
Show resolved
Hide resolved
packages/core/src/node/backend-application-config-provider.spec.ts
Outdated
Show resolved
Hide resolved
paul-marechal
force-pushed
the
mp/application-props-typing
branch
from
2e51dea to
4ba5895
Compare
Rework how the different application configurations are defined to allow partial setting when calling configuration providers. Use default values when setting a partial configuration through the configuration providers.
paul-marechal
force-pushed
the
mp/application-props-typing
branch
from
4ba5895 to
bcb8fbb
Compare
vince-fugnitto
approved these changes
Jun 9, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes look good to me 👍
The feedback I proposed for the *.spec.ts (unit-tests) have also been resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework how the different application configurations are defined to allow
partial setting when calling configuration providers.
Use default values when setting a partial configuration through the
configuration providers.
How to test
Setting partial objects when calling
FrontendApplicationConfigProvider.setandBackendApplicationConfigProvider.setshould work and properly use defaults.Review checklist
Reminder for reviewers