5876-align-outline-expansion-with-vscode#9583
5876-align-outline-expansion-with-vscode#9583colin-grant-work merged 3 commits intoeclipse-theia:masterfrom scottaxcell:5876-align-outline-expansion-with-vscode
Conversation
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
@scottaxcell thank you for the contribution, please be sure to sign the eclipse contributor agreement (eca) with the same email as your authorship so it can be accepted.
vince-fugnitto
added
outline
1) Add expandOnlyOnExpansionToggleClick to TreeProps. 2) Enable expandOnlyOnExpansionToggleClick for OutlineViewWidget. 3) Prevent node expansion in the TreeWidget when expandOnlyOnExpansionToggleClick is enabled. 4) Rename outline-view-tree.ts to outline-view-tree-model.ts to match class name.
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed that the changes align the outline behavior with vscode, meaning that the collapsible node only expands when the toggle is clicked, and not generally like with other trees with the node is clicked 👍 :
I do not have any further comments about the source-code, but I'll give others the chance to review as well.
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
This is working well, but the code could be cleaned up a bit. Please see my comments below.
|
@colin-grant-work thank you for the detailed code review. I have cleaned up the code as you recommended. |
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
Looks good and is working for me. Thanks for the contribution!
* 5876-align-outline-expansion-with-vscode 1) Add expandOnlyOnExpansionToggleClick to TreeProps. 2) Enable expandOnlyOnExpansionToggleClick for OutlineViewWidget. 3) Prevent node expansion in the TreeWidget when expandOnlyOnExpansionToggleClick is enabled. 4) Rename outline-view-tree.ts to outline-view-tree-model.ts to match class name. Co-authored-by: Scott Axcell <scott.axcell@xilinx.com>
3 participants
What it does
Fixes #5876 by aligning the node expand/collapse behavior of the
outline-view-widgetwith VS Code. Previously, the behavior of theoutline-view-widgetmatched the default behavior of atree-widget.The
tree-widgetnow has an optionalexpandOnlyOnExpansionToggleClickprop that will separate the expand/collapse and selection behavior on an expandable node. When this prop is true, expand/collapse of a node will only occur when the expansion toggle is selected.Rename outline-view-tree.ts to outline-view-tree-model.ts to match class name.
How to test
Review checklist
Reminder for reviewers
Signed-off-by: Scott Axcell scott.axcell@xilinx.com