file-search: fix possible infinite recursion when comparing items#9635
Merged
vince-fugnitto merged 1 commit intomasterfrom Jun 25, 2021
Merged
file-search: fix possible infinite recursion when comparing items#9635vince-fugnitto merged 1 commit intomasterfrom
vince-fugnitto merged 1 commit intomasterfrom
Conversation
vince-fugnitto
added
quality
vince-fugnitto
force-pushed
the
vf/file-search-recursion
branch
3 times, most recently
from
e3a3a9c to
766eff1
Compare
paul-marechal
approved these changes
Jun 23, 2021
Member
paul-marechal
left a comment
paul-marechal
left a comment
There was a problem hiding this comment.
Code LGTM, good catch with the recursion.
The commit fixes the possible infinite recursion when comparing two identical quick-open-items, namely with equal `label` and `uri`. The code to compare items compares them first by: - `label`. - `uri` if the labels are equal. The issue is that it attempts to compare `uri` recursively if it is equal. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/file-search-recursion
branch
from
766eff1 to
0804a54
Compare
alvsan09
approved these changes
Jun 23, 2021
Contributor
alvsan09
left a comment
alvsan09
left a comment
There was a problem hiding this comment.
Good find!
Good to see the benefits of unit testing ! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request addresses a possible infinite recursion when comparing two identical
quick-open-items(namely equallabelanduri). Instead of causing the infinite recursion, we will exit early if theuricomparison is equal (value 0).The changes also include
api-testsforfile-search.How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com