fix(types-impl): add toJSON function to Range and Position. fix #9573#9652
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Jun 28, 2021
Merged
Conversation
zWingz
force-pushed
the
bugfix/range-and-position-toJSON
branch
3 times, most recently
from
e92458c to
28be996
Compare
msujew
reviewed
Jun 28, 2021
Signed-off-by: zwing <zhengzwing@gmail.com>
zWingz
force-pushed
the
bugfix/range-and-position-toJSON
branch
from
28be996 to
9072241
Compare
vince-fugnitto
approved these changes
Jun 28, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
@zWingz thank you for your first contribution, from investigating to resolving the issue 👍
I confirmed that the changes work, and that merge-conflict diffs are now displayed:
The code is also consistent with vscode:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
add
toJSONfunction toRangeandPosition, fix #9573How to test
Compare ChangesReview checklist
Reminder for reviewers