Fix tree view selection

[xcariba]

Signed-off-by: Alexander Kozinko xcariba@gmail.com

What it does

Fixes tree view selection #9672. Original implementation always checked old selection state, I think it was a typo.

How to test

1. add the vscode-file-explorer-selection plugin to the example application
2. start the application, open the explorer and perform a selection in the tree-view file-explorer
3. execute the command FileExplorer: Echo Selection
4. a notification should appear with the selection path - on master no selection is present

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

Thank you for the contribution. I imagine it works as expected, but could you please provide a working example in the form of a minimal git repo or in a .vsix file (wrapped in a .zip file)? It would make reviewing this PR a lot easier.

[vince-fugnitto]

We can use the following plugin for test-purposes (modified version of vscode-tree-view-sample:

• https://github.com/vince-fugnitto/vscode-file-explorer-selection/releases/download/0.0.1/custom-view-samples-0.0.1.vsix

[vince-fugnitto]

I confirmed that the changes successfully set the selection using the example plugin:

On master no selection was present.

[vince-fugnitto]

@msujew do you mind performing a quick review as well? I believe it can fit for today's release.

[colin-grant-work]

Looks good to me. I confirm the bug on master and its absence with this code, and the diagnosis of the fault as a typo seems eminently plausible :-).

[msujew]

I can also confirm that the fix is working.