fix file tree scroll bug#9713
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Jul 14, 2021
shuyaqian:fix-scroll
Merged
fix file tree scroll bug#9713vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom shuyaqian:fix-scroll
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
shuyaqian:fix-scroll
Conversation
vince-fugnitto
added
tree
vince-fugnitto
approved these changes
Jul 8, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed that it fixes the issue with scrolling in file dialogs (no more continuous scroll).
I'm not sure if it causes any regressions to other trees but I was not able to identify any.
msujew
approved these changes
Jul 13, 2021
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
I can confirm that this fixes the endless scrolling issue on the file tree. LGTM.
Signed-off-by: shuyaqian 717749594@qq.com
Member
|
@vince-fugnitto push the merge button? You can, right? |
Member
Yes, I just like to let pull-request's sit a bit in case others want to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shuyaqian 717749594@qq.com
What it does
fix #9407
How to test
overflow: autoReview checklist
Reminder for reviewers