Modify closeOnFileDelete default to agree with VSCode

[colin-grant-work]

What it does

Modifies the default value of workbench.editor.closeOnFileDelete to agree with VSCode. We have it set to true, they have it set to false. false is a better default, I think - closing fewer editors automatically is safer.

https://github.com/microsoft/vscode/blob/40b2219e394fd4721934b4007ae0b2890b6b086a/src/vs/workbench/browser/workbench.contribution.ts#L163-L167

How to test

1. Open a workspace with no modifications to the workbench.editor.closeOnFileDelete preference.
2. Check the preferences UI and observe that the preference is set to false, and that setting it to true gives you a blue modified border.
3. Open a file, then delete it, and observe that the editor doesn't close, but does mark itself as (deleted).

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: Colin Grant colin.grant@ericsson.com

[vince-fugnitto]

The changes look good to me, I believe it was a typo to have it true by default as the original pull-request mentioned false was the default (#8731).

The disabling of the preference also makes sense to me, and aligns with vscode as files deleted outside the application are no longer automatically closed within the application 👍