monaco: fix monaco peek styling#9725
Merged
vince-fugnitto merged 1 commit intomasterfrom Jul 15, 2021
Merged
Conversation
The commit updates the monaco peekview-widget `fontFamily` styling. The title and references are now aligned with the styling of vscode. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added
monaco
msujew
approved these changes
Jul 14, 2021
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
I can confirm that the peek display now uses the same font as the rest of the application.
colin-grant-work
approved these changes
Jul 14, 2021
Contributor
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
Changes look reasonable and the bug is indeed fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #9458.
The pull-request updates the monaco peekview-widget
fontFamilystyling.The title and references are now aligned with the styling of vscode.
How to test
theiaas a workspace folderpeek>peek type definitionReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com