Fix import of is-electron (#9729)#9730
Merged
paul-marechal merged 1 commit intoeclipse-theia:masterfrom Jul 13, 2021
Merged
Conversation
Fix eclipse-theia#9729 Signed-off-by: Philip Langer <planger@eclipsesource.com>
paul-marechal
approved these changes
Jul 13, 2021
Contributor
Author
|
Thanks a lot for the fast review @paul-marechal! |
Member
|
It's a trivial change and looking at how the package is implemented vs its declaration it makes a lot of sense. Thanks for the fix! |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9729
Signed-off-by: Philip Langer planger@eclipsesource.com
What it does
This change replaces the import
is-electronwith arequireto workaround the errorHow to test
Please follow the steps to reproduce documented in #9729 and check the console that the error above doesn't occur.
Review checklist
Reminder for reviewers