Fix TaskDto conversion in $fetchTasks#9740
Merged
tsmaeder merged 1 commit intoeclipse-theia:masterfrom Jul 26, 2021
Merged
Conversation
Signed-off-by: Thomas Mäder <tmader@redhat.com>
msujew
approved these changes
Jul 15, 2021
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
I can confirm that the issue exists on master and is addressed nicely by this change. Other tasks continue to work as expected.
Contributor
caseyflynn-google
approved these changes
Jul 15, 2021
Contributor
caseyflynn-google
left a comment
caseyflynn-google
left a comment
There was a problem hiding this comment.
Followed the repro steps in #9605 and confirmed this fixes the issue. Additionally, I ran a few tasks which seem to work properly.
Member
Author
|
@alvsan09 the code involved here is strictly related to how plugins see the tasks. So this change should not have any effect on the issue you mentioned. |
dna2github
pushed a commit
to dna2fork/theia
that referenced
this pull request
Aug 25, 2021
Signed-off-by: Thomas Mäder <tmader@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Mäder tmader@redhat.com
What it does
Use the common conversion method on the main side when fetching tasks from a plugin. Fixes #9605
How to test
Instructions for reproducing the issue are in the linked issue above: make sure the behaviour is correct with the fix present.
Review checklist
Reminder for reviewers