Skip to content

scm: add title for resources#9745

Merged
vince-fugnitto merged 1 commit intomasterfrom
vf/scm-tooltips
Jul 19, 2021
Merged

scm: add title for resources#9745
vince-fugnitto merged 1 commit intomasterfrom
vf/scm-tooltips

Conversation

@vince-fugnitto
Copy link
Member

What it does

Fixes: #9020.

The commit updates the scm view to add tooltips or titles to the elements in the view so end-users can see the full path of resources and folders.

scm-tooltip.mp4

How to test

  1. start the application with a workspace folder under git version control (ex: theia)
  2. perform changes to the workspace (at the root, nested folders, etc.)
  3. open the scm view
  4. verify that changes in the view display the path when hovering over the entries - confirm with tree and list modes

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added ui/ux issues related to user interface / user experience scm issues related to the source control manager labels Jul 15, 2021
@colin-grant-work
Copy link
Contributor

This does indeed add titles to the tree nodes in the SCM tree. I notice, though, that in VSCode the title includes the source control status (modified, new, deleted, etc.) of the file separated from the path by a dot. Would you like to do the same here, or put that off for another PR?

@vince-fugnitto
Copy link
Member Author

This does indeed add titles to the tree nodes in the SCM tree. I notice, though, that in VSCode the title includes the source control status (modified, new, deleted, etc.) of the file separated from the path by a dot. Would you like to do the same here, or put that off for another PR?

Nice suggestion :) I made the update to append the decoration tooltip (ex: modified, deleted, ...) to the tooltip along with the uri.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this enables users to see the full path of the changed file and its scm status. This aligns the behavior to vscode 👍

The commit updates the `scm` view to add `tooltips` or `titles` to the
elements in the view so end-users can see the full path of resources and
folders.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto
Copy link
Member Author

@colin-grant-work I've updated the pull-request following your suggestion to also included the scm status as part of the tooltip.

@vince-fugnitto vince-fugnitto merged commit 334430c into master Jul 19, 2021
@vince-fugnitto vince-fugnitto deleted the vf/scm-tooltips branch July 19, 2021 13:55
@github-actions github-actions bot added this to the 1.16.0 milestone Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scm issues related to the source control manager ui/ux issues related to user interface / user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply tool-tips in the SCM tree

3 participants