Skip to content

quality: fix src/ import statements and typos#9753

Merged
vince-fugnitto merged 2 commits intomasterfrom
vf/fix-src
Jul 19, 2021
Merged

quality: fix src/ import statements and typos#9753
vince-fugnitto merged 2 commits intomasterfrom
vf/fix-src

Conversation

@vince-fugnitto
Copy link
Member

What it does

The pull-request includes the following:

  • update incorrect src/ import statement to use the lib/ instead.
  • miscellaneous typo fixes.
  • renames monaco-gotosymbole-quick-access.ts to monaco-gotosymbol-quick-access.ts due to typo (not included in the changelog as it was not yet released).

How to test

The CI should successfully pass.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added the quality issues related to code and application quality label Jul 16, 2021
@vince-fugnitto vince-fugnitto self-assigned this Jul 16, 2021
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@vince-fugnitto vince-fugnitto merged commit 0cd3071 into master Jul 19, 2021
@vince-fugnitto vince-fugnitto deleted the vf/fix-src branch July 19, 2021 12:11
@github-actions github-actions bot added this to the 1.16.0 milestone Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quality issues related to code and application quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants