plugin: fix hosted-plugin dialog#9764
Merged
vince-fugnitto merged 1 commit intomasterfrom Jul 29, 2021
Merged
Conversation
The commit fixes the `hosted-plugin` dialog to make it operational in both the `browser` and `electron` targets by not directly using the factory and instead using the service. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
alvsan09
reviewed
Jul 22, 2021
Contributor
alvsan09
left a comment
alvsan09
left a comment
There was a problem hiding this comment.
I can confirm that the dialog now appears both when using electron as well as in the browser 👍
I have not checked the actual functionality to successfully load the plugin, etc.. I assume this will be addressed in a different PR.
colin-grant-work
approved these changes
Jul 28, 2021
Contributor
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
I see dialogs on both platforms. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #9763.
The pull-request fixes the
hosted-plugindialog when starting an instance for both the browser and electron targets by not directly using the dialog-factory and instead using the file-dialog-service.How to test
electroninstancehosted plugin: start instance- the dialog should now openbrowserinstancehosted plugin: start instance- the dialog should now openReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com