Fix #9774 Incorrect TreeView item ordering.#9775
Merged
caseyflynn-google merged 1 commit intoeclipse-theia:masterfrom Jul 26, 2021
Merged
Fix #9774 Incorrect TreeView item ordering.#9775caseyflynn-google merged 1 commit intoeclipse-theia:masterfrom
caseyflynn-google merged 1 commit intoeclipse-theia:masterfrom
Conversation
Signed-off-by: Casey Flynn <caseyflynn@google.com>
caseyflynn-google
added
tree
msujew
approved these changes
Jul 26, 2021
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
I can confirm that the issue exists on master and is addressed nicely by this change. Code LGTM as well.
vince-fugnitto
approved these changes
Jul 26, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed with the example plugin that the behavior is fixed with the changes 👍
dna2github
pushed a commit
to dna2fork/theia
that referenced
this pull request
Aug 25, 2021
…ia#9775) Signed-off-by: Casey Flynn <caseyflynn@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Casey Flynn caseyflynn@google.com
What it does
Fixes #9774 by ensuring resolved promises are returned in the same order they are received from a plugin.
How to test
Follow the instructions in #9774 and validate the order of the TreeView items is now correct.
Review checklist
Reminder for reviewers