Fix #9761: Hosted plugin can't be stop or restart#9780
Merged
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom Jul 27, 2021
Merged
Fix #9761: Hosted plugin can't be stop or restart#9780colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom
Conversation
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
Contributor
Author
|
@vince-fugnitto @colin-grant-work Can you approve & merge this small but critical fix? for the next version 1.16? |
Contributor
|
@EstherPerelman, I'd be happy to take a look. Would it be possible for you link to the source for the plugin to test? In my test environment, I can't download |
vince-fugnitto
approved these changes
Jul 27, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed that the change allows us to stop and restart the hosted-plugin using the example provided.
Contributor
Author
It has to work with any kind of |
dna2github
pushed a commit
to dna2fork/theia
that referenced
this pull request
Aug 25, 2021
…se-theia#9780) Fixes an import of the `setTimeout` symbol that was producing unexpected behavior. Signed-off-by: Esther Perelman <esther.perelman@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Esther Perelman esther.perelman@sap.com
What it does
Fix #9761 by removing a problematic import...
How to test
yarn&yarn run compilectrl+shift+p->Hosted Plugin: Start Instancectrl+shift+p->Hosted Plugin: Stop/Restart InstanceReview checklist
Reminder for reviewers