monaco: fix quick-command separator#9783
Merged
vince-fugnitto merged 1 commit intomasterfrom Jul 29, 2021
Merged
Conversation
The following commit fixes the `other commands` separator which should be present only when there are recently used commands. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
alvsan09
approved these changes
Jul 27, 2021
Contributor
alvsan09
left a comment
alvsan09
left a comment
There was a problem hiding this comment.
I have tested the following scenarios and work as expected. 👍
- Exercise new commands and make sure a separator is included before 'otherItems'
- Clear command history and make sure no separator is included
The code looks good to me as well !
Symbolic approval as I am not yet a committer.
msujew
approved these changes
Jul 28, 2021
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
I can confirm that the separator only appears if there are recently used commands in the list. This aligns the behavior with vscode 👍
colin-grant-work
approved these changes
Jul 28, 2021
Contributor
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
Changes make sense, and now the other commands label only appears if there are recent items to contrast them with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The following commit fixes the
other commandsseparator which should be present only when there are recently used commands.quick-command.mp4
How to test
recently usedcommands are separated fromother commands.recently usedlist.Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com