Preferences: Additional Open Preferences Commands#9785
Merged
colin-grant-work merged 1 commit intomasterfrom Jul 28, 2021
Merged
Preferences: Additional Open Preferences Commands#9785colin-grant-work merged 1 commit intomasterfrom
Open Preferences Commands#9785colin-grant-work merged 1 commit intomasterfrom
Conversation
What it does - Adds `Preferences: Open User Preferences` command, which opens the _preferences-view_ with `User` scope. - Adds `Preferences: Open Workspace Preferences` command, which opens the _preferences-view_ with `Workspace` scope. - Modifies `Settings: Open Preferences` command to be able to accept an optional `query` parameter. Pre-populates the search with this query upon opening the _preferences-view_. How to test 1. Open the command palette and search `Preferences: Open User Preferences` or `Preferences: Open Workspace Preferences`. 2. Execute either command and confirm that the _preferences-view_ is opened with the correct scope. Signed-off-by: seantan22 <sean.a.tan@ericsson.com> Signed-off-by: Colin Grant <colin.grant@ericsson.com> Co-authored-by: seantan22 <sean.a.tan@ericsson.com> Co-authored-by: Colin Grant <colin.grant@ericsson.com>
vince-fugnitto
approved these changes
Jul 27, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes look good and work well for the different use-cases 👍
1 task
msujew
approved these changes
Jul 28, 2021
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
Confirmed that everything works well:
- Opening settings (default)
- Opening user preferences
- Opening workspace preferences
- Opening workspace preferences while in user preferences switches the scope correctly
- Using the extension to open preferences with/without a query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7328
Preferences: Open User Preferencescommand, which opens the preferences-view withUserscope.Preferences: Open Workspace Preferencescommand, which opens the preferences-view withWorkspacescope.Settings: Open Preferencescommand to be able to accept an optionalqueryparameter. Pre-populates the search with this query upon opening the preferences-view.How to test
Preferences: Open User PreferencesorPreferences: Open Workspace Preferences.Settings: Open Preferencescommand. Observe that the preferences-view opens with the correct search results displayed.Review checklist
Reminder for reviewers
Signed-off-by: seantan22 sean.a.tan@ericsson.com
Signed-off-by: Colin Grant colin.grant@ericsson.com