fix(scm): add onDidChangeCommitTemplate event#9792
Merged
paul-marechal merged 1 commit intoeclipse-theia:masterfrom Aug 26, 2021
Merged
fix(scm): add onDidChangeCommitTemplate event#9792paul-marechal merged 1 commit intoeclipse-theia:masterfrom
paul-marechal merged 1 commit intoeclipse-theia:masterfrom
Conversation
Signed-off-by: zwingz <zhengzwing@gmail.com>
msujew
approved these changes
Jul 28, 2021
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
Signed-off-by: zwingz <zhengzwing@gmail.com>
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
Signed-off-by: zwingz <zhengzwing@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Signed-off-by: zwingz zhengzwing@gmail.com
What it does
add
onDidChangeCommitTemplateevent toSCMextensions, close #9778In
vscode-git, when our repo has some change, It will get the inputTemplate and set it to SCM input (updateModalState)and it will call getInputTemplate and getMergeMessage
The SCM will call updateSourceControl and fire
onDidChangeCommitTemplateEmitterBut Theia does not provide a
onDidChangeCommitTemplatelistenersSo the
vscode-gitcann't update the SCM-inputVscode References
How to test
example/browserdependencies@theia/gitvscode-git@1.49.3totheiaPluginsNote the SCM input, should be with value

Merge branch 'conflict'