Add @vscode/codicons dependency to core package#9828
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Aug 6, 2021
Merged
Add @vscode/codicons dependency to core package#9828vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
@vscode/codicons dependency to core package#9828vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
Conversation
Member
I don't think so (while we always can to be safe), as in our guide for new dependencies we can do the check ourselves, and I confirmed that the license is "creative commons" which is an approved license. |
linhanyu
approved these changes
Aug 3, 2021
Contributor
linhanyu
left a comment
There was a problem hiding this comment.
I can approve those change were effective in our electron( Macos / Windows )
linhanyu
approved these changes
Aug 3, 2021
a6abf2f to
cbf9929
Compare
Member
|
It looks like we finally ran into the issue where codicons are not available, something we predicted a while ago if With this change, we should be able to update all icons in the framework to |
vince-fugnitto
approved these changes
Aug 3, 2021
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed that the change fixes the reported issue 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Closes #9826
Adds the
@vscode/codiconspackage to the core Theia package. Currentlycodiconsare only available oncemonacohas been loaded to the DOM. This loads anycodiconsat startup without the need to include monaco in Theia. I've confirmed that all currently usedcodiconsclasses are contained in the referenced css file, except fortree-item-expanded, which I've replaced withchevron-down.cc @vince-fugnitto does this require a CQ?
How to test
monacopackages. See the followingdependenciessection:Review checklist
Reminder for reviewers