Update DebugRequestTypes to reflect DAP changes#9833
Merged
colin-grant-work merged 1 commit intomasterfrom Aug 5, 2021
Merged
Conversation
Signed-off-by: Colin Grant <colin.grant@ericsson.com>
colin-grant-work
added
dap
vince-fugnitto
approved these changes
Aug 4, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed it looks correct based on the DAP specifications:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
This PR updates the Theia types used to reflect Debug Adapter Protocol types. There have been some updates around which UI may need to be built, but in the meantime, this at least allows adopters / extension writers to write code for the new requests and events without running afoul of our type declarations. At the moment something like
session.sendRequest('readMemory', ...)is treated as an error because we just haven't declared that possibility.How to test
If it builds, then we're referring to real things in the DAP.
Review checklist
Reminder for reviewers
Signed-off-by: Colin Grant colin.grant@ericsson.com