Make PluginViewRegistry class more extensible#9847
Merged
colin-grant-work merged 1 commit intoeclipse-theia:masterfrom Aug 10, 2021
Merged
Conversation
vince-fugnitto
approved these changes
Aug 5, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes look good to me 👍
vince-fugnitto
added
extensibility
msujew
approved these changes
Aug 6, 2021
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
The changes look reasonable to me as well.
Contributor
Author
|
@vince-fugnitto @msujew thank you for approving! are you able to merge? |
packages/plugin-ext/src/main/browser/view/plugin-view-registry.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Esther Perelman <esther.perelman@sap.com>
EstherPerelman
force-pushed
the
more-extensible-plugin-view-registry
branch
from
cd1917e to
625c021
Compare
Contributor
Author
|
@vince-fugnitto @msujew @colin-grant-work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Esther Perelman esther.perelman@sap.com
What it does
Move some code to separate functions to make it easy to override some logic, This should help with the fix of #9800 as suggested here
How to test
f1->View: Reset Layout workbench-> see the icons on the left sidebar initialized well.f1->toggle <some_view> view-> toggle view as expected.Review checklist
Reminder for reviewers