plugin: fix starting hosted-plugins#9874
Merged
vince-fugnitto merged 1 commit intomasterfrom Aug 13, 2021
Merged
Conversation
The commit fixes the start of the hosted-plugin mode when selecting resource in the dialog. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
|
tested, and works for me |
|
Built and tested it. Works as it should.
|
StanZGenchev
approved these changes
Aug 12, 2021
1 task
colin-grant-work
approved these changes
Aug 13, 2021
Contributor
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
I confirm that no hosted plugin session is started on master, and that one is started with these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #9871
The pull-request fixes an issue where the hosted-plugin mode cannot be started when selecting a resource from the dialog.
Previously, we relied on a
UriSelectionbut we now refactored the dialog to use the service instead which returns us aUridirectly. The logic to set thepluginLocationwas adjusted to support the new type.How to test
example-browserapplicationhosted plugin: start instance(using F1)theia-hello-worldproject folderReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com