Bind handleExpansionToggleDblClickEvent in TreeWidget

[scottaxcell]

What it does

Fixes #9876 .

How to test

See #9876 steps to reproduce.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: Scott Axcell scott.axcell@xilinx.com

[msujew]

Thank you for your contribution @scottaxcell, that looks like it does the job. I have one issue with this though:

This is a breaking change, as it does not allow to override handleExpansionToggleDblClickEvent as a method in subclasses of TreeWidget anymore. You would instead have to override doHandleExpansionToggleDblClickEvent.

I would usually recommend to instead simply replace its calling site with event => this.handleExpansionToggleDblClickEvent(event) in line 575. However, your approach keeps everything in line with other methods like toggle which is implemented in the same way. So I don't really care which way you go, but going with your current one requires you to describe your breaking changes in the changelog.

[scottaxcell]

@msujew thanks for the feedback. In keeping with the current convention, I'll leave the change as is and update the changelog.

[msujew]

I can confirm that the issue exists on master and is nicely addressed by this change:

• Double clicking a toggle node on master leads to an error stating: this is undefined.
• Double clicking a toggle node with the changes in place correctly stops the propagation of the event.

[colin-grant-work]

@vince-fugnitto, would you be willing to restart the tests for this PR? I don't believe this code is responsible for the failure, but always nice to have all green.