Fix 9914: vscode builtin GIT showing incorrect tree state#9915
Fix 9914: vscode builtin GIT showing incorrect tree state#9915vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
Conversation
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
I can confirm that the issue exists on master and is addressed by this change nicely:
- On
masterinstalling git1.50.0or1.52.1(version linked in the issue), both exhibit the issue ❌ - With your changes in place, both extension versions behave as expected ✔️
Clean solution, code looks good to me 👍
msujew
added
scm
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
@EstherPerelman I confirmed that the bug exists on master and the pull-request resolves the problem 👍
My only nitpick would be to update the commit message to provide additional details as to why the changes are necessary, it was not immediately obvious looking at the code.
EstherPerelman
force-pushed
the
fix-9914
branch
2 times, most recently
from
302b526 to
bb18526
Compare
Due to incorrect `scm` tree view after executing file actions (like `stage`/`unstage`), Added `onDidChangeResources` listener to the `scm` provider which recreates `scm` tree on every resource change. Signed-off-by: Esther Perelman <esther.perelman@sap.com>
EstherPerelman
force-pushed
the
fix-9914
branch
from
bb18526 to
b698540
Compare
@vince-fugnitto I have updated the commit, Is that clearer now? (if it is - please merge it), thanks. |
3 participants
Signed-off-by: Esther Perelman esther.perelman@sap.com
What it does
Fixes #9914 by adding a listener to git resources changes
How to test
Follow #9914 Steps to Reproduce
Review checklist
Reminder for reviewers