preferences: Fix search term on open via menu

[msujew]

What it does

Closes #9931

Fixes the issue by simply checking for the string type before passing the argument into the search term.

How to test

1. Open the preferences menu via the settings menu in the bottom left.
2. Observe an empty search bar

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

@msujew I confirmed that it fixes the issue with the preferences, however I believe it introduces a regression in the following use-case:

pull-request:

context-menu-regression.mp4

master:

menu-master.mp4

[colin-grant-work]

@msujew I confirmed that it fixes the issue with the preferences, however I believe it introduces a regression in the following use-case:

Very timely: there's the legitimate use case for it (maybe - I'm not sure that's how the menu should work...).

[msujew]

however I believe it introduces a regression

Ah, as I thought we rely somewhere on that undocumented behavior. :/

Alright, I'll look for a more localized fix for this issue.

[colin-grant-work]

This solves the problem nicely, and definitely looks like a safer approach. 👍

[vince-fugnitto]

I confirmed that the change fixes the issue on master 👍
It is also self-contained and does not cause any regressions.