multi root repository : fixed selected repository is not populated.#9954
Merged
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom Aug 26, 2021
Merged
multi root repository : fixed selected repository is not populated.#9954vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
vince-fugnitto merged 1 commit intoeclipse-theia:masterfrom
Conversation
fixed selected repository is not populated for git menu commands when using multi root repository Signed-off-by: ChayaLau <chaya.lau@sap.com>
33b5e28 to
eadd1f6
Compare
Contributor
Author
|
@vince-fugnitto , @msujew - can you please approve and merge it before the next release? it is only a minor fix, and i tested to make sure there is no regression when using the theia git. thanks! |
packages/plugin-ext/src/main/browser/menus/menus-contribution-handler.ts
Show resolved
Hide resolved
Contributor
|
@colin-grant-work @vince-fugnitto @msujew who can merge it? |
vince-fugnitto
approved these changes
Aug 25, 2021
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed that the behavior works well when testing with the builtin git plugin:
- single-root stashing works well
- multi-root stashing works well - we are no longer prompted to choose the repository, and instead the currently selected one is used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed selected repository is not populated for git menu commands when using multi root repository
Signed-off-by: Chaya Lau chaya.lau@sap.com
What it does
populates the selected repository to
vscode gitcommands and preventing thechoose a repositorywindow in multi root repositoryHow to test
before fix : window had show with choose a repository command.
after fix : the stash skips the choose a repository window and uses the selected repository as the source repo.
Review checklist
Reminder for reviewers