Skip to content

Bump API version to 1.53.2#9959

Merged
tsmaeder merged 1 commit intoeclipse-theia:masterfrom
tsmaeder:9193_bump_version_1.53.2
Aug 31, 2021
Merged

Bump API version to 1.53.2#9959
tsmaeder merged 1 commit intoeclipse-theia:masterfrom
tsmaeder:9193_bump_version_1.53.2

Conversation

@tsmaeder
Copy link
Member

@tsmaeder tsmaeder commented Aug 25, 2021

Signed-off-by: Thomas Mäder tmader@redhat.com

What it does

Bumps the default vscode API version to 1.53.2. The linked issue proposes 1.52.0, but I believe the the changes between 1.52.0 and 1.53.2 should be binary compatible or already implemented in theia (see SecretsStorage).

#9193

How to test

I tested by starting VS Code Java 0.81

Review checklist

Reminder for reviewers

Signed-off-by: Thomas Mäder <tmader@redhat.com>
@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Aug 26, 2021
@paul-marechal paul-marechal added this to the 1.18.0 milestone Aug 26, 2021
********************************************************************************/

export const VSCODE_DEFAULT_API_VERSION = '1.50.0';
export const VSCODE_DEFAULT_API_VERSION = '1.53.2';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsmaeder as part of the bump, should we also think about bumping our versions of the builtins (so we make use of the latest api). In theory we can now consume the vscode-builtin-extension-pack and use the mechanism of #9956 to exclude plugins we don't want (ex: vscode-git at the moment).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vince-fugnitto those are all worthy goals, but IMO not reasons to delay the merging of this PR. Testing through the built-ins (and changing the mechanism to consume them) would take considerable time and is not part of the issue this PR is fixing.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm alright with merging this. I couldn't find any glaring issues related to missing APIs. We can test for regressions related to bumped extension versions during the coming month.

@tsmaeder tsmaeder merged commit a7d63a0 into eclipse-theia:master Aug 31, 2021
RomanNikitenko pushed a commit that referenced this pull request Sep 16, 2021
Signed-off-by: Thomas Mäder <tmader@redhat.com>
RomanNikitenko pushed a commit that referenced this pull request Sep 16, 2021
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@mtsmfm mtsmfm mentioned this pull request Sep 20, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vscode issues related to VSCode compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants