Bump API version to 1.53.2#9959
Conversation
Signed-off-by: Thomas Mäder <tmader@redhat.com>
| ********************************************************************************/ | ||
|
|
||
| export const VSCODE_DEFAULT_API_VERSION = '1.50.0'; | ||
| export const VSCODE_DEFAULT_API_VERSION = '1.53.2'; |
There was a problem hiding this comment.
@tsmaeder as part of the bump, should we also think about bumping our versions of the builtins (so we make use of the latest api). In theory we can now consume the vscode-builtin-extension-pack and use the mechanism of #9956 to exclude plugins we don't want (ex: vscode-git at the moment).
There was a problem hiding this comment.
@vince-fugnitto those are all worthy goals, but IMO not reasons to delay the merging of this PR. Testing through the built-ins (and changing the mechanism to consume them) would take considerable time and is not part of the issue this PR is fixing.
msujew
left a comment
There was a problem hiding this comment.
I'm alright with merging this. I couldn't find any glaring issues related to missing APIs. We can test for regressions related to bumped extension versions during the coming month.
Signed-off-by: Thomas Mäder <tmader@redhat.com>
Signed-off-by: Thomas Mäder <tmader@redhat.com>
Signed-off-by: Thomas Mäder tmader@redhat.com
What it does
Bumps the default vscode API version to 1.53.2. The linked issue proposes 1.52.0, but I believe the the changes between 1.52.0 and 1.53.2 should be binary compatible or already implemented in theia (see
SecretsStorage).#9193
How to test
I tested by starting VS Code Java 0.81
Review checklist
Reminder for reviewers