fix git annotations bug#9999
fix git annotations bug#9999colin-grant-work merged 1 commit intoeclipse-theia:masterfrom shuyaqian:fix-annotations
Conversation
colin-grant-work
left a comment
There was a problem hiding this comment.
This is an improvement over the old code, but I was still able to get a bad result when the message overflowed:
Since not all reviewers may be comfortable with non-Latin characters, you may want to include a test commit as part of this PR with a message that includes non-Latin characters, and add instructions in your PR description for where to find those messages.
done. |
|
@colin-grant-work Even with the recent changes I'm still experiencing the issue you mentioned previously: |
Hm... thanks for checking. Gotta try more scripts... :-) |
|
It looks like Japanese, Korean, and Arabic are all causing problems: I used these messages:
The Arabic message is also displaying the end rather than the beginning - but handling RTL text correctly may be beyond the scope of this PR. |
I have fixed it. |
|
@shuyaqian, it looks like a problem with a reference to a non-existent namespace field is crashing the build. |
That's ok now. |
colin-grant-work
left a comment
There was a problem hiding this comment.
The style specifications now look robust, and I can't identify any cases in which the time message overflows.
Signed-off-by: shuyaqian 717749594@qq.com
msujew
left a comment
There was a problem hiding this comment.
Looks good to me as well. Using different scripts/languages I could no longer reproduce the issue 👍






Signed-off-by: shuyaqian 717749594@qq.com
What it does
fix #9998
How to test
Review checklist
Reminder for reviewers