Added TX_ENABLE_FIQ_SUPPORT to the feature-macro assembly stage - #610
Merged
fdesbiens merged 1 commit intoAug 13, 2026
Merged
Conversation
eclipse-threadx#608 assembled the code behind TX_ENABLE_VFP_SUPPORT, TX_LOW_POWER and TX_ENABLE_EXECUTION_CHANGE_NOTIFY, and missed TX_ENABLE_FIQ_SUPPORT, which guards assembly in 145 files across the A and R profile ports. All 145 assemble today, so this adds no fix, only the regression protection the other three already have. Also recorded why TX_ENABLE_IRQ_NESTING and TX_ENABLE_FIQ_NESTING are not in the list, since their absence otherwise looks like the same oversight. They guard no assembly in the trees this script walks: the nesting start and end routines are separate files compiled unconditionally, and the macros only feed the TX_PORT_SPECIFIC_BUILD_OPTIONS bitfield in tx_port.h. Adding them would assemble nothing new while implying coverage that does not exist. Verified with Arm Toolchain for Embedded 22.1.0: 711 of 711 assembly sources, then 37 of 37 VFP, 145 of 145 FIQ, 8 of 8 TX_LOW_POWER and 218 of 218 TX_ENABLE_EXECUTION_CHANGE_NOTIFY. Assisted-by: Claude Code (Opus 5) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#608 assembled the code behind
TX_ENABLE_VFP_SUPPORT,TX_LOW_POWERandTX_ENABLE_EXECUTION_CHANGE_NOTIFY, and missedTX_ENABLE_FIQ_SUPPORT, whichguards assembly in 145 files across the A and R profile ports.
All 145 assemble today, so this adds no fix — only the regression protection the
other three already have. It is the same argument as #608: a guarded path that
nothing assembles is a path where the next
.arch-class mistake waits.It also records why
TX_ENABLE_IRQ_NESTINGandTX_ENABLE_FIQ_NESTINGare notin the list, since their absence otherwise reads as the same oversight I am fixing
here. They guard no assembly in the trees this script walks: the nesting start and
end routines are separate files compiled unconditionally, and the macros only feed
the
TX_PORT_SPECIFIC_BUILD_OPTIONSbitfield intx_port.h. Adding them wouldassemble nothing new while implying coverage that does not exist.
Verified with Arm Toolchain for Embedded 22.1.0: