dtls.c: fix missing alerts when receiving a ClientHello in epoch 0. - #112
Merged
Merged
Conversation
boaks
force-pushed
the
fix_client_hello_alerts
branch
2 times, most recently
from
December 23, 2021 19:07
e09e32a to
8a4e39e
Compare
boaks
force-pushed
the
fix_client_hello_alerts
branch
from
February 4, 2022 08:56
8a4e39e to
d13ca5c
Compare
obgm
reviewed
Feb 25, 2022
obgm
left a comment
obgm
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, only minor comments.
In the commit message, please change as follows:
- "alert back, if" → "alert back if"
- "a address-verified" → "an address-verified"
| return CALL(ctx, write, ephemeral_peer->session, buf, sizeof(buf)); | ||
| } | ||
|
|
||
| static int dtls_0_send_alert_from_err(dtls_context_t *ctx, dtls_ephemeral_peer_t *ephemeral_peer, int err) |
Contributor
There was a problem hiding this comment.
I would kindly request to honor the maximum column limit of 80 characters, especially as the opening brace should be on the same line as the closing parenthesis for the argument list.
Contributor
Author
There was a problem hiding this comment.
As in dtls_prepare_record?
Cleanup peer and send alert back if processing an address-verified ClientHello fails. Fixes wrong content-type in dtls_0_send_alert as well. Signed-off-by: Achim Kraus <achim.kraus@bosch.io>
boaks
force-pushed
the
fix_client_hello_alerts
branch
from
February 25, 2022 15:02
d13ca5c to
97eb178
Compare
Contributor
Author
|
Done. |
Contributor
|
Looks good, ready to go... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup peer and send alert back, if processing a address-verified
ClientHello fails.
Fixes wrong content-type in dtls_0_send_alert as well.
Signed-off-by: Achim Kraus achim.kraus@bosch.io