Add workflow for codeql analysis using Java 17#112
Merged
stevenhartley merged 2 commits intoeclipse-uprotocol:mainfrom Jun 3, 2024
Merged
Add workflow for codeql analysis using Java 17#112stevenhartley merged 2 commits intoeclipse-uprotocol:mainfrom
stevenhartley merged 2 commits intoeclipse-uprotocol:mainfrom
Conversation
Contributor
Author
|
hmm, need to adjust the workflow as it is failing atm |
Contributor
Author
|
set build-mode to none as suggested for java only projects, but now autobuild is running and seems to be able to successfully build the project ... picture me surprised, but at least it works. The workflow still fails but because code scanning is still set to default mode, and the upload of the results fails because of that. Once it is set to advanced mode it should also work uploading the results, so should be fine to merge imho. |
stevenhartley
approved these changes
Jun 3, 2024
stevenhartley
left a comment
stevenhartley
left a comment
There was a problem hiding this comment.
LGTM Thank you so much @netomi !!!!
HemirAli
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4698.
After this PR has been merged we need to alter the configuration of the repo to switch to advanced mode for CodeQL.