Merged
Conversation
Cloudevents were used in older versions of the protocol but they have since been replaced with our own message format called UMessage. The cloudevent code was copied over to up-java so that we could support backwards compatibility however given that UUri and UUID changes, it was no longer possible to simply convert from 1.3.6 cloudevent to 1.5.x UMessage. After further study of deployed solutions, it was found that we can support the old CloudEvents and 1.3..x uEs (and deployments) using the older SDK so that this library does not require supporting CloudEvents at all. This commit removes all the CloudEvent code so that we no longer have to maintain it. #121
|
Code coverage report is ready! 📈
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloudevents were used in older versions of the protocol but they have since been replaced with our own message format called UMessage. The cloudevent code was copied over to up-java so that we could support backwards compatibility however given that UUri and UUID changes, it was no longer possible to simply convert from 1.3.6 cloudevent to 1.5.x UMessage. After further study of deployed solutions, it was found that we can support the old CloudEvents and 1.3..x uEs (and deployments) using the older SDK so that this library does not require supporting CloudEvents at all. This commit removes all the CloudEvent code so that we no longer have to maintain it.
Also added missing code coverage now that CloudEvent code was removed.
#121