Update up-core-api protos#13
Merged
stevenhartley merged 3 commits intoeclipse-uprotocol:mainfrom Feb 20, 2024
neelam-kushwah:updatecoreprotos
Merged
Update up-core-api protos#13stevenhartley merged 3 commits intoeclipse-uprotocol:mainfrom neelam-kushwah:updatecoreprotos
stevenhartley merged 3 commits intoeclipse-uprotocol:mainfrom
neelam-kushwah:updatecoreprotos
Conversation
stevenhartley
left a comment
stevenhartley
left a comment
There was a problem hiding this comment.
@neelam-kushwah I see that the generated protos are checked in, is that in error? Could we setup the project to be like the others that it pulls in a version of the core-api and then builds?
Contributor
Author
|
@stevenhartley As of now, I am including the generated protos in up-python. However, as I update up-python, I will pull the protos from up-core-api and generate the proto files, just as I did for up-simulator. |
Contributor
Author
|
Added script to pull and compile 'up-core-api' protos and removed all checked in proto files. |
stevenhartley
approved these changes
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.