Remove vendor specific references in test files#31
Merged
neelam-kushwah merged 3 commits intoeclipse-uprotocol:mainfrom May 8, 2024
Merged
Remove vendor specific references in test files#31neelam-kushwah merged 3 commits intoeclipse-uprotocol:mainfrom
neelam-kushwah merged 3 commits intoeclipse-uprotocol:mainfrom
Conversation
There were a few references to proprietary properties in the test cases. Those have been removed.
|
Code coverage report is ready! 📈
|
stevenhartley
changed the title
stevenhartley
requested changes
May 7, 2024
stevenhartley
left a comment
stevenhartley
left a comment
There was a problem hiding this comment.
Please remove on the known vendor specific product name, you can keep gm.com in the URLs
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
neelam-kushwah
approved these changes
May 8, 2024
Contributor
neelam-kushwah
left a comment
neelam-kushwah
left a comment
There was a problem hiding this comment.
LGTM Thanks @matthewd0123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few references to proprietary properties in the test cases. Those have been removed.