Added .dockerignore/trimmed docker images#268
Open
deas wants to merge 1 commit intoeclipsesource:masterfrom
Open
Added .dockerignore/trimmed docker images#268deas wants to merge 1 commit intoeclipsesource:masterfrom
deas wants to merge 1 commit intoeclipsesource:masterfrom
Conversation
cd57118 to
4b8e529
Compare
RamsesAupart
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This trims the size of the docker images. I think the most important bit is
.dockerignorepreventing node.out from ending up in the images. The android image currently ending up being 2.7GB (the NDK weighing in at 2.3GB) still seems a bit odd.