[core] Extend core/i18n substates with actions to set schema and uischema#1181
Merged
edgarmueller merged 2 commits intoeclipsesource:masterfrom Dec 12, 2018
Merged
Conversation
Member
|
would it make sense to extend the examples in order to try this feature out? |
Contributor
Author
|
I'll add the example code I've tested with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces changes that are meant to be used in the following fashion:
During initialization one is ought to register the respective localized versions of the schema/UI schemas, e.g.:
Likewise for UI schemas.
Then, within the locale switcher of the respective app (which needs to be custom anyway, I think), locales can be switched via the new actions (this could be probably be improved a bit since we need to pass the entire state ATM):
This will cause the root schema/UI schema to be updated and hence the entire forms managed by JSON Forms will be re-rendered with the new schema/UI schema