Editable combos don't show value list #1182#1223
Merged
edgarmueller merged 2 commits intoeclipsesource:masterfrom Jan 28, 2019
Merged
Editable combos don't show value list #1182#1223edgarmueller merged 2 commits intoeclipsesource:masterfrom
edgarmueller merged 2 commits intoeclipsesource:masterfrom
Conversation
- show vale list on select, but keep filtering active on keytype
AlexandraBuzila
force-pushed
the
fix-1182
branch
from
ed96891 to
a2a8f59
Compare
Member
Author
|
The updated commit keeps the filtering active while a key is pressed, but shows the full option list when the control is selected. |
| export class AutocompleteControlRenderer extends JsonFormsControl { | ||
| @Input() options: string[]; | ||
| filteredOptions: Observable<string[]>; | ||
| shouldNotFilter: boolean; |
Contributor
There was a problem hiding this comment.
Could we remove the negation here and invert the logic here? It just keeps confusing me 😅
Member
Author
There was a problem hiding this comment.
Changed 😁
I also change the event type that is used for updating the filter from key up to key down, as the first key was otherwise ignored.
- update filter on key down events, as the first key is otherwise ignored
Member
Author
|
I created #1239 for adding tests for this. |
edgarmueller
approved these changes
Jan 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove filter from autocomplete renderer.