Skip to content

Show unfocused description config#1414

Merged
edgarmueller merged 4 commits intoeclipsesource:masterfrom
dosium:feature/show-unfocused-description-config
Jun 24, 2019
Merged

Show unfocused description config#1414
edgarmueller merged 4 commits intoeclipsesource:masterfrom
dosium:feature/show-unfocused-description-config

Conversation

@Lily418
Copy link

@Lily418 Lily418 commented Jun 21, 2019

I was doing user testing yesterday and found the user didn't know what unit one of the inputs required, this was it the description but this only showed when they focused the field.

I'd like the option to show unfocused helper text.
Screenshot 2019-06-21 at 15 38 16

@eneufeld
Copy link
Member

I agree the new option would be useful. I would not mix in commit 1b8d51f (which is pr #1413 ) into this though.

@Lily418
Copy link
Author

Lily418 commented Jun 24, 2019

@eneufeld opps, that wasn't meant to be there. Thanks have updated now.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 81.377% when pulling 94d5039 on HelixCentre:feature/show-unfocused-description-config into 37065bd on eclipsesource:master.

@eneufeld
Copy link
Member

@edgarmueller what is your take on this? I think this is a nice extension.

@edgarmueller
Copy link
Contributor

I agree, actually we have the same requirement in another project, so I'm all in favor for it!

@edgarmueller edgarmueller self-requested a review June 24, 2019 15:59
Copy link
Contributor

@edgarmueller edgarmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@edgarmueller edgarmueller merged commit 482d328 into eclipsesource:master Jun 24, 2019
@edgarmueller edgarmueller added this to the 2.3.0 milestone Jun 24, 2019
@edgarmueller
Copy link
Contributor

On a sidenote: this adds to the long list of TODOs about documentation, I've updated #1203 accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants