Add examples app with bundled react vanilla, material examples#2056
Merged
Add examples app with bundled react vanilla, material examples#2056
Conversation
8 tasks
Member
|
@lucas-koehler can you resolve the conflicts? |
lucas-koehler
force-pushed
the
gh-1706_examples-app
branch
from
6b59747 to
2147d8a
Compare
Contributor
Author
|
@sdirix I resolved the conflict. |
sdirix
requested changes
Jan 2, 2023
Member
sdirix
left a comment
sdirix
left a comment
There was a problem hiding this comment.
Works for me in when including the suggested changes. Good job!
| "build": "rollup -c rollup.config.js", | ||
| "dev": "webpack --config webpack/webpack.dev.js && webpack-dev-server --config webpack/webpack.dev.js --env=dev --inline", | ||
| "clean": "rimraf lib coverage dist .nyc_output 2> /dev/null", | ||
| "example:bundle": "rollup -c rollup.example.config.js", |
Member
There was a problem hiding this comment.
I would name this build:example-app
This introduces a new private package `examples-app` to create a simple web page that ultimately has child pages for every example. In this initial commit, only the react vanilla and material examples are added. Therefore, they are bundled with rollup to be able to run as standalone pages. - Add rollup configs to bundle react vanilla and material examples - Add required dev deps and upgrade rollup dev dep to ^2.78.0 for all packages - change material deps to ~5.2.2 because latest 5.x versions break api for Autocomplete - Add private package `examples-app` with a script to aggregate the examples - Add root level npm script to create the examples app - regenerate package-lock.json Part of #1706
Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>
lucas-koehler
force-pushed
the
gh-1706_examples-app
branch
from
25e1d5e to
677c708
Compare
Contributor
Author
|
@sdirix Thanks for the review and suggestions. I applied the suggestions and renamed the scripts as suggested. A brief retest did not show any problems :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new private package
examples-appto create a simple web page that ultimately has child pages for every example.In this initial commit, only the react vanilla and material examples are added. Therefore, they are bundled with rollup to be able to run as standalone pages.
examples-appwith a script to aggregate the examplesPart of #1706
Netlify instructions
Build examples app:
App will be located in
packages/examples-app/dist/