Add Object and OneOf renderer to vue3-vanilla#2151
Add Object and OneOf renderer to vue3-vanilla#2151sdirix merged 2 commits intoeclipsesource:masterfrom
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for the contribution ❤️ In general we are definitely interested in these renderers 👍 . Please make sure that the build succeeds (there seem to be some Typescript errors) and sign the CLA. Afterwards we'll take a look. Thanks! |
f5a4dd1 to
695ea4f
Compare
695ea4f to
ed9187e
Compare
|
Update: added some tests for the new renderers, but was not able to test the dialog in the OneOfRenderer (showModal() is not a function). It worked in manual testing though. Let me know if there is anything missing. |
sdirix
left a comment
There was a problem hiding this comment.
Looks good in general! Can you take a look at my comments?
ed9187e to
a6a2f17
Compare
|
@sdirix Thank you for the review. I tried to adress them as good as I can and also fixed linting. |
a291594 to
ea7a5cd
Compare
|
Now also the build is passing for me - sorry for the inconvenience, but had some trouble getting the build system to work locally |
ea7a5cd to
71dd23f
Compare
71dd23f to
356347b
Compare
sdirix
left a comment
There was a problem hiding this comment.
Very nice! Thank you again for the contribution! ❤️
We ported the Object and OneOf renderers from vue2 to vue3 - would be nice to have them upstream