feat: respect "default" values when creating new elements in an array#2206
Merged
sdirix merged 1 commit intoeclipsesource:masterfrom Nov 13, 2023
Merged
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AlexandraBuzila
force-pushed
the
feat/array-defaults
branch
2 times, most recently
from
c84f008 to
ac6a096
Compare
sdirix
reviewed
Nov 9, 2023
sdirix
reviewed
Nov 9, 2023
sdirix
reviewed
Nov 9, 2023
AlexandraBuzila
force-pushed
the
feat/array-defaults
branch
from
ac6a096 to
bb308bf
Compare
Member
Author
|
Thank you for the review, Stefan! I integrated your comments. |
sdirix
reviewed
Nov 10, 2023
sdirix
reviewed
Nov 10, 2023
AlexandraBuzila
force-pushed
the
feat/array-defaults
branch
from
bb308bf to
86e013a
Compare
Initialize new array elements with their default values. Fixes default value returned for string schemas with a date format. Fixes eclipsesource#2195 Contributed on behalf of STMicroelectronics Signed-off-by: Alexandra Buzila <abuzila@eclipsesource.com>
sdirix
force-pushed
the
feat/array-defaults
branch
from
86e013a to
8f95160
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize new array elements with their default values.
Can be tested in the
Array with defaultsexample.Fixes #2195
Contributed on behalf of STMicroelectronics