Merged
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LukasBoll
force-pushed
the
fix/angular-datepicker
branch
2 times, most recently
from
3471299 to
4faf843
Compare
sdirix
requested changes
Feb 19, 2024
Member
sdirix
left a comment
sdirix
left a comment
There was a problem hiding this comment.
The bug seems to be fixed! However I encountered another issue during testing:
It's not possible for me to enter a "schemaBased" date via the keyboard into the textual input. The date always clears.
That's the first input of the "Dates" example
LukasBoll
force-pushed
the
fix/angular-datepicker
branch
6 times, most recently
from
3237b92 to
d9f78ae
Compare
Member
|
@LukasBoll Can you resolve the conflicts? |
replace toISOString(), which formats dates based on the UTC time zone with Angular DatePipe, which works with local time zones
Use a custom dateFormatter to enable the date picker format option. Enable the JSON Forms view options.
LukasBoll
force-pushed
the
fix/angular-datepicker
branch
from
d9f78ae to
a7bfafa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses the "Angular date picker: selected date is off by one day" #2033 issue.
Starting from this implementation, I added the option to provide date formats and views in the uischema.